fix: js and css vite preloading broken - #2787
Conversation
Signed-off-by: Tomasz Trillò <tomasz.trillo@dataport.de>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Tomasz Trillò <tomasz.trillo@dataport.de>
aa24e22 to
b0656ef
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Due to the partial renaming, the CSS and JS preloading broke.
The appName is "teams", but the app's ID is "circles". As a result, window.OC.filePath() generates the wrong path to the JS and CSS files during preloading.
By resetting the appName in vite.config.ts and setting the assetsPrefix, the change is minimal and has no side effects.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)