fix: Set a token to shares retrieved from the DB - #1865
Merged
Conversation
When accessing a circle share from the public share view, the `addOpenGraphHeaders` method was erroring in `DefaultPublicShareTemplateProvider`. This is due to the fact that the `$share` object for circles share does not contain a token, so the computation of the `$shareUrl` was failing. This commit ensures that the share has a token. Signed-off-by: Louis Chemineau <louis@chmn.me>
Contributor
Author
|
/backport to stable31 |
artonge
changed the title
susnux
approved these changes
Feb 17, 2025
ArtificialOwl
approved these changes
Feb 18, 2025
Member
|
/backport to stable30 |
Member
|
/backport to stable29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When accessing a circle share from the public share view, the
addOpenGraphHeadersmethod was erroring inDefaultPublicShareTemplateProvider. This is due to the fact that the$shareobject for circles share does not contain a token, so the computation of the$shareUrlwas failing.This commit ensures that the share has a token.
Regression introduced by nextcloud/server#45652