Use $group->getDisplayName() instead of just the GID for the display … - #1297
Open
rotdrop wants to merge 2 commits into
Open
Use $group->getDisplayName() instead of just the GID for the display …#1297rotdrop wants to merge 2 commits into
rotdrop wants to merge 2 commits into
Conversation
rotdrop
force-pushed
the
bugfix/use-group-display-name
branch
from
May 5, 2023 15:35
de02180 to
93122b7
Compare
mejo-
approved these changes
Jun 6, 2023
mejo-
left a comment
mejo-
left a comment
Member
There was a problem hiding this comment.
Code changes look sensible to me. What do you think @ArtificialOwl?
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
susnux
approved these changes
Mar 29, 2024
Member
|
Conflict in lib/Service/MembersService.php is going to require manual intervention... |
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
This was referenced Aug 29, 2024
This was referenced Jun 17, 2026
CarlSchwan
approved these changes
Aug 10, 2026
CarlSchwan
force-pushed
the
bugfix/use-group-display-name
branch
from
August 10, 2026 09:45
93122b7 to
5b9c96d
Compare
Member
|
After resolving the conflicts the patch is now a one-liner |
AndyScherzinger
force-pushed
the
bugfix/use-group-display-name
branch
from
August 12, 2026 16:00
5b9c96d to
2c6dc87
Compare
Member
|
@CarlSchwan @mejo- @susnux psalm is unhappy |
This was referenced Aug 18, 2026
…name of "group circles". Fixes nextcloud#1296. Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
AndyScherzinger
force-pushed
the
bugfix/use-group-display-name
branch
from
August 20, 2026 12:16
2c6dc87 to
65d6512
Compare
susnux
reviewed
Aug 20, 2026
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…name of "group circles".
Fixes #1296.