fix: recurrence rule truncation on nth occurrence save - #8910
Merged
SebastianKrupinski merged 1 commit intoSep 9, 2026
Merged
SebastianKrupinski merged 1 commit into
SebastianKrupinski merged 1 commit into
Conversation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Contributor
Author
|
/backport to stable6.6 |
Contributor
Author
|
/backport to stable6.5 |
SebastianKrupinski
marked this pull request as ready for review
September 9, 2026 13:35
SebastianKrupinski
requested review from
GVodyanov and
tcitworld
as code owners
September 9, 2026 13:35
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
odzhychko
approved these changes
Sep 9, 2026
SebastianKrupinski
deleted the
fix/recurrence-rule-truncation-on-nth-occurrence-save
branch
September 9, 2026 14:46
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue
@nextcloud/calendar-js's forkItem() (used whenever you load any occurrence for editing) mutates the forked occurrence's own copy of RRULE, it recalculates COUNT down to "occurrences remaining from this point forward." That's correct for the "this and future" truncate flow, but the same forked object is used in series-scope save, this incorrectly truncates the series
Testing