fix: make period header translation reactive - #8880
Merged
Conversation
When the moment.js locale was loaded after first rendering the header did not rerender displaying the wrong translation. Fixes #8756 Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
odzhychko
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
September 6, 2026 20:11
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SebastianKrupinski
assigned
SebastianKrupinski and
odzhychko and unassigned
SebastianKrupinski
SebastianKrupinski
approved these changes
Sep 6, 2026
Contributor
|
/backport to stable6.6 |
backportbot
Bot
added
the
backport-request
Contributor
|
Was this just caused by how the function was loaded after the typescript refactor? or would this happen in 6.5 also? |
SebastianKrupinski
deleted the
8756-month-name-in-the-period-header-is-untranslated-on-first-render-store-defaults-to-en-until-mounted
branch
September 6, 2026 21:26
github-project-automation
Bot
moved this from 🏗️ In progress
to ☑️ Done
in 💌 📅 👥 Groupware team
backportbot
Bot
removed
the
backport-request
Contributor
Author
This bug was not introduced during the refactor. |
Contributor
Author
|
/backport to stable6.5 |
backportbot
Bot
added
the
backport-request
backportbot
Bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the moment.js locale was loaded after first rendering the header did not rerender displaying the wrong translation.
Fixes #8756
Before
Did not automatically updates translation once moment.js locale is available.
It only changed translation after once changing the date.
Screencast.From.2026-09-06.22-00-21.mp4
After
Automatically updates translation once moment.js locale is available.
Screencast.From.2026-09-06.22-01-12.mp4