fix: bell icon for events with reminders

[madbob]

Added the bell icon to events having reminders.

I've found that the event.extendedProps.darkText property was calculated only to determine the color of that (broken and missing) icon, that the hexToRGB() function only existed to calculate that value, and that generateTextColorForHex() (the only one calling hexToRGB()) was never used. So I preferred to enforce fill color of SVG icons to var(--color-main-text) (the same color adopted for text) and made the bold move to remove all that redundant code (and related tests).

Fixes #4553

[SebastianKrupinski]

Hi @madbob

Thanks for the PR. We'll have to test all these changes.

[SebastianKrupinski]

Hi,

The changes look good, just some minor things to address.

[madbob]

Yes, of course.

Most of changes occurred in the unit tests (meant to test themselves :-P ), other changes are mostly reorganization of existing code.

A note about the hard coded SVG paths: I've modified also the existing ones as them were designed for a different SVG viewport, and I've preferred to normalize all of them. The source of those SVG was not specified, I bet those were just different variants of those already in use from Material Design; I've specified in comments the file from which I got them, for future reference.

[SebastianKrupinski]

Most of changes occurred in the unit tests (meant to test themselves :-P ), other changes are mostly reorganization of existing code.

Yes but unit test don't test visual changes

[codecov]

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/fullcalendar/rendering/eventDidMount.js	40.00%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

[SebastianKrupinski]

/backport to stable6.6

[SebastianKrupinski]

/backport to stable6.5