Fix icon usage - #8849
Merged
Merged
Conversation
odzhychko
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
September 4, 2026 12:30
Contributor
Author
|
/backport to stable6.6 |
backportbot
Bot
added
the
backport-request
Contributor
Author
|
/backport to stable6.6 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SebastianKrupinski
requested changes
Sep 4, 2026
SebastianKrupinski
left a comment
SebastianKrupinski
left a comment
Contributor
There was a problem hiding this comment.
I don't know if this really needs to be back ported.
If you do want to pack port this, then all the commits need to be "fix"
This prevents console warnings. The intended icon is already added as a slot. Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
Use the `icon` slot instead of the unsupported `icon` property. Do not set `size` as it has not effect. Set decorative property consistently. Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
odzhychko
force-pushed
the
fix-icon-usage
branch
from
September 4, 2026 14:35
42e9c95 to
381b34e
Compare
Contributor
Author
|
In general I'm also not sure if to back port fixes for small visual glitches or not. This specific fixes should be easily back portable to I changed every thing from |
SebastianKrupinski
approved these changes
Sep 4, 2026
backportbot
Bot
removed
the
backport-request
Contributor
If it actually fixes an issue, it should be back ported to all applicable stable versions. |
Contributor
Author
|
/backport to stable6.5 |
backportbot
Bot
added
the
backport-request
4 tasks
backportbot
Bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some icon usage.
Includes small visual fixes for users and less warning in console for developers.
Commit messages include details on why changes needed to be made.
NcActionButtonNcActionButtonInvalid prop: type check failed for prop "icon". ... at <NcActionButton key="dayGridMonth" icon=class: 'animation-rotate'NcActionTextScreencast.From.2026-09-04.14-21-08.mp4
Screencast.From.2026-09-04.14-22-46.mp4
NcEmptyContent