fix(editor): support Cmd key for editor shortcuts on macOS - #8720
Conversation
|
Thanks for the review — pushed a follow-up that switches the editor shortcuts to
Happy to adjust further if needed. |
There was a problem hiding this comment.
The editor mixin is already a common library between both editors, why do we now need to extract and abstract this in to a composable? useHotKey is already a composable, so we are wrapping a @nextcloud composable in a local composable?
There was a problem hiding this comment.
Agreed — the local wrapper is gone. EditFull / EditSimple now call @nextcloud/vue useHotKey directly from setup(); useEditorHotKeys.js was removed.
da86e8c to
795ed24
Compare
|
Thanks @odzhychko and @SebastianKrupinski — updated to call |
58f4089 to
e98f9fb
Compare
odzhychko
left a comment
There was a problem hiding this comment.
@xhon-pelushi #8720 (comment) is still open.
Just inline the logic into setup in EditorMixin (or is there a reason why it doesn't work?). Also no need for the new code comments.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
a7336a1 to
5c6cf32
Compare
I made the changes. |
|
Note: Shortcut keys work, but not so well for recurring events |
|
/backport to stable6.6 |
|
/backport to stable6.5 |
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
5c6cf32 to
0c90374
Compare
Summary
@nextcloud/vueuseHotKeyso macOS uses Cmd and other platforms use Ctrl (not both).useHotKeydirectly fromEditFullandEditSimplesetup().Fixes #8715
Test plan