Skip to content

fix: cancel confirmation dialog - #7892

Merged
SebastianKrupinski merged 1 commit into
mainfrom
fix/cancel-confirmation-dialog-again
Jan 22, 2026
Merged

fix: cancel confirmation dialog#7892
SebastianKrupinski merged 1 commit into
mainfrom
fix/cancel-confirmation-dialog-again

Conversation

@GVodyanov

@GVodyanov GVodyanov commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Change wording, close button not working, and dirty state handling

@GVodyanov GVodyanov self-assigned this Jan 22, 2026
@GVodyanov GVodyanov added the 2. developing Work in progress label Jan 22, 2026
@codecov

codecov Bot commented Jan 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/mixins/EditorMixin.js 0.00% 2 Missing ⚠️
src/store/calendarObjectInstance.js 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@GVodyanov
GVodyanov force-pushed the fix/cancel-confirmation-dialog-again branch 2 times, most recently from c4d1174 to 38371d3 Compare January 22, 2026 16:25
@GVodyanov
GVodyanov marked this pull request as ready for review January 22, 2026 16:32
@GVodyanov GVodyanov added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 22, 2026
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Tested works good! Words are changed.

image

Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
@GVodyanov
GVodyanov force-pushed the fix/cancel-confirmation-dialog-again branch from 38371d3 to cd30895 Compare January 22, 2026 17:22
@SebastianKrupinski
SebastianKrupinski merged commit 7932ac9 into main Jan 22, 2026
30 of 40 checks passed
@SebastianKrupinski
SebastianKrupinski deleted the fix/cancel-confirmation-dialog-again branch January 22, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants