feat: allow sharee to copy public link of a shared calendar

[ammaratef45]

Screenshot for before:

Screenshot for after:

[SebastianKrupinski]

HI @ammaratef45

Thank you for the PR. This change will need to get approved by product design.

Also, the text in the menu needs to be aligned properly and should have an icon in front of it.

[SebastianKrupinski]

@nimishavijay @kra-mo

[kra-mo]

Also, the text in the menu needs to be aligned properly and should have an icon in front of it.

Right, also no "PublicLink" heading. But the feature makes sense.

[ammaratef45]

Thanks @SebastianKrupinski and @kra-mo

I've updated the PR, here is how it looks now

[SebastianKrupinski]

Hi @ammaratef45

It looks good, now I just need you to do a couple more things...

1. rename the commit to "feat: (title)"
2. address the linting errors (npm run lint:fix)
3. squash all the commit in to one
4. rebase to the latest version

And is there a ticket that this addresses?

[ammaratef45]

Hi @SebastianKrupinski, I did the things you requested, and no there was not a ticket, I was about to cut one when I found none but I figured I could try and implement it myself, hopefully that is not spamming the repo or breaking your protocol, happy to adjust going forward

[kra-mo]

Approved from the design side

[SebastianKrupinski]

Hi @ammaratef45

So 1 to 3 are good, but for the rebase can you run "git rebase -i origin/main', I think you did a merge rebase originally, and there are 2 commit now one for your changes and one for the rebase. I tried to do this for you but it seems I can't push changes to your branch.

[ammaratef45]

So 1 to 3 are good, but for the rebase can you run "git rebase -i origin/main', I think you did a merge rebase originally, and there are 2 commit now one for your changes and one for the rebase. I tried to do this for you but it seems I can't push changes to your branch.

Aha gotcha, I assumed you meant rebase with upstream main (my origin is my fork), if that is the case I just did that!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[ammaratef45]

@SebastianKrupinski following up on this, I ran the command npm run test:unit:coverage locally both against my branch and main and noticed at least some of the errors in both

is this blocked on the checks passing? and do we have known bad unit tests?

[SebastianKrupinski]

is this blocked on the checks passing? and do we have known bad unit tests?

Its just a bad unit test... can you rebase this again... we've fixed the tests in the main branch already...

PR is NOT blocked...

[ammaratef45]

is this blocked on the checks passing? and do we have known bad unit tests?

Its just a bad unit test... can you rebase this again... we've fixed the tests in the main branch already...

PR is NOT blocked...

Okay yaaay, just rebased it!

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[ammaratef45]

@SebastianKrupinski Hello, I've just re-based the PR again

if you have some cycles to merge that would be cool!

[GVodyanov]

Looks and works good!

[SebastianKrupinski]

Merged! Thank you for the PR and your efforts!