Skip to content

fix: from alignment - #7341

Merged
st3iny merged 1 commit into
mainfrom
fix/issue-7334-fix-from-alignment
Sep 4, 2025
Merged

st3iny merged 1 commit into
mainfrom
fix/issue-7334-fix-from-alignment

Conversation

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Summary

  • Fixed "From" alignment

After
image

Before
image

@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

/backport to stable6.0

@backportbot backportbot Bot added the backport-request A backport was requested for this pull request label Sep 3, 2025
@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

/backport to stable5.5

@codecov

codecov Bot commented Sep 3, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 13.68%. Comparing base (2e17227) to head (0b8f6b4).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ents/Editor/Properties/PropertyTitleTimePicker.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7341   +/-   ##
=======================================
  Coverage   13.68%   13.68%           
=======================================
  Files         218      218           
  Lines       11174    11174           
  Branches     2697     2684   -13     
=======================================
  Hits         1529     1529           
  Misses       9295     9295           
  Partials      350      350           
Flag Coverage Δ
javascript 13.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SebastianKrupinski
SebastianKrupinski force-pushed the fix/issue-7334-fix-from-alignment branch from 1b17c65 to 833e73a Compare September 3, 2025 16:22

@st3iny st3iny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not solve the problem fully on my machine (Firefox).

image

@SebastianKrupinski

SebastianKrupinski commented Sep 4, 2025 •

Copy link
Copy Markdown
Contributor Author

Does not solve the problem fully on my machine (Firefox).

The PR was to address the lack of space between the word "from" and the input, but you are right input is slightly of to the left, Its barely even noticeable on me screen

@st3iny

st3iny commented Sep 4, 2025

Copy link
Copy Markdown
Member

Yeah, I noticed that. But we can't fix one problem just to create another one.

@SebastianKrupinski

Copy link
Copy Markdown
Contributor Author

Yeah, I noticed that. But we can't fix one problem just to create another one.

I agree I fixed it already

image

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
SebastianKrupinski force-pushed the fix/issue-7334-fix-from-alignment branch from 833e73a to 0b8f6b4 Compare September 4, 2025 14:58

@st3iny st3iny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny
st3iny merged commit e94c234 into main Sep 4, 2025
39 of 40 checks passed
@st3iny
st3iny deleted the fix/issue-7334-fix-from-alignment branch September 4, 2025 15:20
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Sep 4, 2025
@backportbot backportbot Bot removed the backport-request A backport was requested for this pull request label Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Development

Successfully merging this pull request may close these issues.

2 participants