Skip to content

Set task start to allow visualization as regular event - #3033

Closed
foxtrotzulu94 wants to merge 2 commits into
nextcloud:mainfrom
foxtrotzulu94:issue/2669-task-start-date
Closed

Set task start to allow visualization as regular event#3033
foxtrotzulu94 wants to merge 2 commits into
nextcloud:mainfrom
foxtrotzulu94:issue/2669-task-start-date

Conversation

@foxtrotzulu94

Copy link
Copy Markdown
Contributor

This PR enables tasks to be visualized as regular events, when their start date is available. Fixes #2669 and will primarily affect Day and Week views of any calendar. See attached screenshots for reference.

image

Signed-off-by: Javier E. Fajardo <javier@fajardo.io>
@foxtrotzulu94
foxtrotzulu94 force-pushed the issue/2669-task-start-date branch from 847cd00 to 9caf749 Compare April 20, 2021 07:42
@codecov

codecov Bot commented Apr 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3033 (9caf749) into master (883d3da) will increase coverage by 65.11%.
The diff coverage is n/a.

❗ Current head 9caf749 differs from pull request most recent head 8cbb9e2. Consider uploading reports for the commit 8cbb9e2 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master    #3033       +/-   ##
=============================================
+ Coverage     29.18%   94.29%   +65.11%     
  Complexity      116      116               
=============================================
  Files           155        9      -146     
  Lines          5561      421     -5140     
  Branches        822        0      -822     
=============================================
- Hits           1623      397     -1226     
+ Misses         3938       24     -3914     
Flag Coverage Δ Complexity Δ
javascript ? ?
php 94.29% <ø> (ø) 116.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/components/Editor/Alarm/AlarmList.vue
src/utils/timezone.js
src/models/calendarShare.js
...mponents/Editor/Invitees/OrganizerNoEmailError.vue
...NavigationHeader/AppNavigationHeaderDatePicker.vue
src/fullcalendar/eventSources/eventSource.js
...nents/Editor/Properties/PropertySelectMultiple.vue
src/utils/localization.js
src/utils/date.js
src/router.js
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883d3da...8cbb9e2. Read the comment docs.

@tcitworld tcitworld left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix eslint issues and have a look at the failed test?

Not sure about this one, as some people may have tasks ongoing for several days/weeks/months, they only care about the due date and don't want it to pollute their calendar.

Signed-off-by: Javier E. Fajardo <javier@fajardo.io>
@foxtrotzulu94

Copy link
Copy Markdown
Contributor Author

Can you fix eslint issues and have a look at the failed test?

Not sure about this one, as some people may have tasks ongoing for several days/weeks/months, they only care about the due date and don't want it to pollute their calendar.

Thanks for taking a look. Issues have been fixed!

And what you pointed out in terms of people not wanting to pollute their calendars was one of my worries as well. I've been testing out the change for a couple of days now and ran into this as well. Maybe it can be controlled through another configuration setting in the future?

@foxtrotzulu94
foxtrotzulu94 requested a review from tcitworld April 24, 2021 01:16
@szaimen

szaimen commented Sep 30, 2021

Copy link
Copy Markdown
Contributor

What would be more useful instead (IMO) would be putting tasks into the all-day section only (also the ones that have a time set) and also showing tasks that are overdue and not done yet always only in the all-day section of today.
This is how Google Calendar handles this, afaik.
Then the tasks don't completely polute the calendar view and you will be able to work in a useful way with them.

@foxtrotzulu94 @jancborchardt @nimisha-vijay what do you think about that?

@krillin666

Copy link
Copy Markdown

Is there any update on this (very essential) PR?

@asandikci

asandikci commented Mar 26, 2023

Copy link
Copy Markdown

Is there any update for this feature? I think this is really necessary. And there could be a configuration in the settings for people who don't want this feature and don't want to pollute their calendars
@foxtrotzulu94 @tcitworld

@Rudd-O

Rudd-O commented Sep 1, 2026

Copy link
Copy Markdown

Also fixes #8824 .

@Rudd-O

Rudd-O commented Sep 1, 2026

Copy link
Copy Markdown

Can someone please help pushing this through?

@Rudd-O

Rudd-O commented Sep 1, 2026

Copy link
Copy Markdown

Is there any update for this feature? I think this is really necessary. And there could be a configuration in the settings for people who don't want this feature and don't want to pollute their calendars @foxtrotzulu94 @tcitworld

It is already possible to turn off task display in calendar. It's in the settings.

@Rudd-O

Rudd-O commented Sep 1, 2026

Copy link
Copy Markdown

@foxtrotzulu94 I have taken the liberty of fixing your merge conflict here:

https://github.com/Rudd-O/calendar/tree/issue/2669-task-start-date

Anyone is free to reopen the PR using my branch — but I would prefer if the original author cherry-picked and took credit for my change.

@Rudd-O

Rudd-O commented Sep 1, 2026

Copy link
Copy Markdown

Actually Javier is no longer active on GH so I will open my own PR.

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

Supersede by #8825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature request Feature: Tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include task start date / time in calendar view

9 participants