Set task start to allow visualization as regular event - #3033
Set task start to allow visualization as regular event#3033foxtrotzulu94 wants to merge 2 commits into
Conversation
Signed-off-by: Javier E. Fajardo <javier@fajardo.io>
847cd00 to
9caf749
Compare
Codecov Report
@@ Coverage Diff @@
## master #3033 +/- ##
=============================================
+ Coverage 29.18% 94.29% +65.11%
Complexity 116 116
=============================================
Files 155 9 -146
Lines 5561 421 -5140
Branches 822 0 -822
=============================================
- Hits 1623 397 -1226
+ Misses 3938 24 -3914
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
tcitworld
left a comment
There was a problem hiding this comment.
Can you fix eslint issues and have a look at the failed test?
Not sure about this one, as some people may have tasks ongoing for several days/weeks/months, they only care about the due date and don't want it to pollute their calendar.
Signed-off-by: Javier E. Fajardo <javier@fajardo.io>
Thanks for taking a look. Issues have been fixed! And what you pointed out in terms of people not wanting to pollute their calendars was one of my worries as well. I've been testing out the change for a couple of days now and ran into this as well. Maybe it can be controlled through another configuration setting in the future? |
|
What would be more useful instead (IMO) would be putting tasks into the all-day section only (also the ones that have a time set) and also showing tasks that are overdue and not done yet always only in the all-day section of today. @foxtrotzulu94 @jancborchardt @nimisha-vijay what do you think about that? |
|
Is there any update on this (very essential) PR? |
|
Is there any update for this feature? I think this is really necessary. And there could be a configuration in the settings for people who don't want this feature and don't want to pollute their calendars |
|
Also fixes #8824 . |
|
Can someone please help pushing this through? |
It is already possible to turn off task display in calendar. It's in the settings. |
|
@foxtrotzulu94 I have taken the liberty of fixing your merge conflict here: https://github.com/Rudd-O/calendar/tree/issue/2669-task-start-date Anyone is free to reopen the PR using my branch — but I would prefer if the original author cherry-picked and took credit for my change. |
|
Actually Javier is no longer active on GH so I will open my own PR. |
|
Supersede by #8825 |
This PR enables tasks to be visualized as regular events, when their start date is available. Fixes #2669 and will primarily affect Day and Week views of any calendar. See attached screenshots for reference.