Register the sticker reference provider only if the related task type is available - #391
Merged
julien-nc merged 6 commits intoNov 7, 2025
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
…er and reference provider, rely on the listener to conditionally inject the sticker reference script Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…tically Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…eneration is not available Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…on is enabled while image generation is not available Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/noid/sticker-picker-only-if-tasktype-available
branch
from
November 5, 2025 16:35
5fa031d to
a6bdc15
Compare
Member
Author
|
@janepie I addressed all the topics we discussed. The initial comment was updated. |
lukasdotcom
approved these changes
Nov 7, 2025
lukasdotcom
left a comment
Member
There was a problem hiding this comment.
I think I went through all the combinations to test. Looks good 🚀
julien-nc
deleted the
fix/noid/sticker-picker-only-if-tasktype-available
branch
November 7, 2025 15:26
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was always registered so the sticker picker could be used even if:
The main fix is
Additional aspect of the fix for later:
taskProcessingManager->getAvailableTaskTypeIdsfor that (to efficiently check if the task type is available in Application.php) and we still support NC 30-31 which don't have this method.Please try to test all scenarios in your dev setup:
If all of those are enabled/available, the "AI sticker generation" picker should be there in the UI (I use Talk to test).
Additional fixes: