Skip to content

Fix stop polling when needed - #356

Merged
julien-nc merged 4 commits into
mainfrom
fix/355/stop-polling
Sep 9, 2025
Merged

Fix stop polling when needed#356
julien-nc merged 4 commits into
mainfrom
fix/355/stop-polling

Conversation

@julien-nc

Copy link
Copy Markdown
Member

closes #355

  • Fix stop polling when closing the assistant while polling a classic task
  • Fix stop polling when closing the assistant while polling a message generation in the chat UI (wrong component method name, onDestroy() does not exist anymore in vue3. We now use beforeUnmount().
  • Bonus: Get rid of the eslint warning about the axios.isCancel import

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…ytime the ChattyLLMInputForm component is unmounted)

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…ios.isCancel

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc added bug Something isn't working 3. to review labels Sep 8, 2025
@julien-nc julien-nc mentioned this pull request Sep 9, 2025
…e stop polling

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

@kyteinsky kyteinsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@julien-nc
julien-nc merged commit 072e7ec into main Sep 9, 2025
9 checks passed
@julien-nc
julien-nc deleted the fix/355/stop-polling branch September 9, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop polling a task when needed

2 participants