Skip to content

fix(settings): trust reverse proxy for client IP in rate limiting #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miaulalala wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(settings): trust reverse proxy for client IP in rate limiting #1813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

## [Unreleased]

### Fixed

- Trust the reverse proxy's `X-Forwarded-For` header for login rate limiting, so failed-login limits apply per visitor instead of collapsing into a single site-wide bucket.

## [4.11.3] - 2026-01-05

### Changed
Expand Down
6 changes: 6 additions & 0 deletions nextcloudappstore/settings/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,12 @@
"manage_email": "3/h/user",
}

# We run behind a single reverse proxy, which sets X-Forwarded-For. Without
# this, allauth's rate limiting (e.g. ACCOUNT_RATE_LIMITS["login_failed"]
# above) falls back to REMOTE_ADDR, which is the proxy's own address for
# every request -- collapsing per-IP limits into a single site-wide bucket.
ALLAUTH_TRUSTED_PROXY_COUNT = 1

SITE_ID = 1

# Allauth configuration
Expand Down
Loading