feat: allow for custom message for approval and rejection - #330
Merged
Conversation
lukasdotcom
commented
Sep 22, 2025
lukasdotcom
commented
Member
lukasdotcom
requested review from
julien-nc
and removed request for
julien-nc
September 22, 2025 15:19
lukasdotcom
force-pushed
the
feat/message
branch
4 times, most recently
from
September 22, 2025 15:55
cfcbd0b to
db8e458
Compare
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
lukasdotcom
force-pushed
the
feat/message
branch
from
September 22, 2025 16:00
db8e458 to
a52e701
Compare
julien-nc
requested changes
Sep 24, 2025
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
julien-nc
requested changes
Sep 24, 2025
julien-nc
left a comment
julien-nc
left a comment
Member
There was a problem hiding this comment.
There is no more approve or reject file action for a pending file. It would be nice to have a "Approve or reject" action that opens the modal, just like when clicking the inline action.
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Member
Author
Added it: 
|
julien-nc
approved these changes
Oct 6, 2025
julien-nc
left a comment
julien-nc
left a comment
Member
There was a problem hiding this comment.
Tested, works like a charm 👍 Thanks for adding the unified non-inline action.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.