Skip to content

Add .editorconfig to help with coding style - #199

Closed
HalibutGitWiz wants to merge 2 commits into
nextcloud:mainfrom
HalibutGitWiz:editorconfig
Closed

Add .editorconfig to help with coding style#199
HalibutGitWiz wants to merge 2 commits into
nextcloud:mainfrom
HalibutGitWiz:editorconfig

Conversation

@HalibutGitWiz

Copy link
Copy Markdown

This PR adds an EditorConfig. It's a widely supported file format which can help a lot with respecting Nextcloud coding style.

If your editor supports it, whatever default formatting settings you use will be overridden by those in .editorconfig when working on your Nextcloud app. And if your editor doesn't support it, it does nothing so it's harmless.

@provokateurin

Copy link
Copy Markdown
Member

I don't think this is necessary, as we already have one at https://github.com/nextcloud/server/blob/master/.editorconfig. It is automatically used if you develop the app inside the apps/ directory and for everything else we already have php-cs-fixer, eslint and stylelint.

@HalibutGitWiz

Copy link
Copy Markdown
Author

I don't think this is necessary, as we already have one at https://github.com/nextcloud/server/blob/master/.editorconfig. It is automatically used if you develop the app inside the apps/ directory

This is true if your Nextcloud dev install is a clone of the Git repository. But if you work in a production release, .editorconfig is not included. If all you plan to do is develop an app, you don't really need the whole Nextcloud repo.

@provokateurin

Copy link
Copy Markdown
Member

But if you work in a production release, .editorconfig is not included. If all you plan to do is develop an app, you don't really need the whole Nextcloud repo.

This is not recommended, so we won't specifically support it. You should always use a proper git checkout of the server to develop apps.

@HalibutGitWiz

Copy link
Copy Markdown
Author

This is not recommended, so we won't specifically support it. You should always use a proper git checkout of the server to develop apps.

Ok, then. Thanks for your answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants