fix(unified-search): handle slow server search for loader spinner - #17474
Conversation
|
APK file: https://github.com/nextcloud/android/actions/runs/31708377060/artifacts/9185933527 |
2e502d8 to
8c4e910
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/32112686853/artifacts/9315869222 |
|
APK file: https://github.com/nextcloud/android/actions/runs/32114634969/artifacts/9316393935 |
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
…ncryption Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
c8827ca to
dd68a06
Compare
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://github.com/nextcloud/android/actions/runs/32115440530/artifacts/9316888528 |
daniele-verducci
left a comment
There was a problem hiding this comment.
It seems good to me. I'm not sure how to simulate a slow server, so I tested throttling down the connection and the search part works as intended on timeout. Also checked with an encrypted folder and the more button is correctly hidden.
Issue
In slow server instance spinner always showed and files are loading in main thread.
Changes
Loading spinner has max ceiling value
Loads the file in IO thread
Bind function directly takes
OCFilethus no need for each bind database operation