Skip to content

fix(unified-search): handle slow server search for loader spinner - #17474

Merged
alperozturk96 merged 3 commits into
masterfrom
fix/search-encrypted-files-endless-indicator
Aug 18, 2026
Merged

fix(unified-search): handle slow server search for loader spinner#17474
alperozturk96 merged 3 commits into
masterfrom
fix/search-encrypted-files-endless-indicator

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Issue

In slow server instance spinner always showed and files are loading in main thread.

Changes

Loading spinner has max ceiling value
Loads the file in IO thread
Bind function directly takes OCFile thus no need for each bind database operation

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/31708377060/artifacts/9185933527
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 force-pushed the fix/search-encrypted-files-endless-indicator branch from 2e502d8 to 8c4e910 Compare August 18, 2026 07:42
@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32112686853/artifacts/9315869222
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 added this to the Nextcloud App 35.0.0 milestone Aug 18, 2026
@alperozturk96 alperozturk96 added the performance 🚀 Performance improvement opportunities (non-crash related) label Aug 18, 2026
@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32114634969/artifacts/9316393935
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
…ncryption

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness5959
Dodgy code207207
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance3939
Security1919
Total384384

@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32115440530/artifacts/9316888528
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me. I'm not sure how to simulate a slow server, so I tested throttling down the connection and the search part works as intended on timeout. Also checked with an encrypted folder and the more button is correctly hidden.

@alperozturk96
alperozturk96 merged commit eed4cbe into master Aug 18, 2026
22 of 24 checks passed
@alperozturk96
alperozturk96 deleted the fix/search-encrypted-files-endless-indicator branch August 18, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review performance 🚀 Performance improvement opportunities (non-crash related)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants