Reworked "add new" menu to better support multiple office suites

[daniele-verducci]

Fix nextcloud/files-clients#114
Fix nextcloud/files-clients#128

🖼️ Screenshots

🏚️ Before	🏡 After
(did not exist)

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

• The content of this PR was partly or fully generated using AI

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/31710340741/artifacts/9186734530
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/31775512074/artifacts/9209879722
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[alperozturk96]

@kra-mo @daniele-verducci @tobiasKaminsky

Regarding design

These are just details if it requires more effort I think we can skip it.

---

1. There’s a bit too much space between the icon and the title. Both items should also have some padding. When I tap on them, the icon touches the top edge, so it should be centered.

---

2. Maybe the right arrow should be tinted, since the gray on white doesn’t have enough contrast.

---

3. Does this need to have the exact same height as the previous bottom sheet? Shouldn’t it take up only as much space as the number of items requires?

The back arrow currently spans the full width of the bottom sheet, like the other actions. Would it be possible to make it 48.dp size instead?

[daniele-verducci]

Hey @alperozturk96 , thanks for the feedback!
Ftm I didn't rework the cosmetic part, let's wait for feedback by @kra-mo

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/31788727775/artifacts/9214729118
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[alperozturk96]

@daniele-verducci You can fix :

with

'./gradlew spotlessApply'.

[daniele-verducci]

Yes, sorry, I still don't have enabled the pre-commit checks... fixed!

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/31790537711/artifacts/9215432268
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[kra-mo]

@daniele-verducci, Alper is right about the height and the contrast :)

When I tap on them, the icon touches the top edge, so it should be centered.

For this, I'd also add that it should have rounded corners.

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/31815200041/artifacts/9224951094
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[daniele-verducci]

Hey @alperozturk96 and @kra-mo , I've made some of the changes, but I'm finding challenging some others.

Made:

Margins and rounded edges on the ripple effect

Challenging:

The first one is technical: all the buttons are colored with colorMaterialButtonContent() (from MaterialViewThemeUtils), that expects a MaterialButton. Unfortunately i had to add the arrov as an ImageView over the MaterialButton, as it doesn't allow to specify drawableStart/drawableEnd, but only a single icon (yes, I feel it's ugly, but didn't come out with a better idea...). How can I theme that one? I'm probably missing something obvious here...
Relevant code:

android/app/src/main/res/layout/file_list_actions_bottom_sheet_fragment.xml

Line 87 in 52051a1

<ImageView

The second one: I made the back button square instead than full width, but I'm not sure how to position it:

• if I leave it to the left, when I press it the ripple effect touches the margin of the sheet

• while if I apply the standard margin, it does appear too far from the sheet margin unless it's pressed.

Any hint?

[daniele-verducci]

Changes in behaviour

Changed the order of the entried to comply with nextcloud/files-clients#126
The new order is: Office documents from Direct Editing, then Office Documents from Capabilities, then all the others.
(please see 091e432#diff-b01b35dab1d0d6d56538e7cf85b0f1b8b0d1d87c1a2a37da37f1669fe14b3fdfR189 and following lines)

Cosmetic changes

Styled the "More" and "Back" button using the instance's theme color

At this point I should have applied all the changes discussed above. The current back button position is the one that avoids the ripple touching the border (see:

), but can be changed very easily if that's the case.

[alperozturk96]

[github-actions]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17473-IT-master-11-53

[daniele-verducci]

Ouch 🤦
Sorry... fixed

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	32	32
Correctness	59	59
Dodgy code	207	207
Experimental	1	1
Malicious code vulnerability	2	2
Multithreaded correctness	25	25
Performance	39	39
Security	19	19
Total	384	384

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/32109517145/artifacts/9314672261
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)