Skip to content

Show cached data in account detail view when server is not reachable - #17464

Merged
alperozturk96 merged 2 commits into
masterfrom
fix/15236-account-detail-page-empty
Aug 12, 2026
Merged

Show cached data in account detail view when server is not reachable#17464
alperozturk96 merged 2 commits into
masterfrom
fix/15236-account-detail-page-empty

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Fix #15236

🖼️ Screenshots

🏚️ Before 🏡 After
before image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

This is an improvement originated from #15236 . I was unable to reproduce the issue in the ticket, but I noticed the account detail view was left empty. I populated the data in the top banner using the cached data (logic from accounts list) and fixed a bug preventing the error message to be shown. Also changed the second line of the error message to a more human readable one (the error from the lib is still logged).

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci daniele-verducci self-assigned this Aug 12, 2026
@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness6060
Dodgy code216216
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance4040
Security1919
Total395395

@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 35.0.0 milestone Aug 12, 2026
@daniele-verducci daniele-verducci linked an issue Aug 12, 2026 that may be closed by this pull request
@alperozturk96
alperozturk96 merged commit c0b4e3f into master Aug 12, 2026
20 of 23 checks passed
@alperozturk96
alperozturk96 deleted the fix/15236-account-detail-page-empty branch August 12, 2026 08:28
@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Account switcher fails when server offline

3 participants