Improve large file download#17169
Open
alperozturk96 wants to merge 7 commits into
Open
Conversation
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
commented
Jun 11, 2026
| MockKAnnotations.init(this) | ||
| every { mockFileUploaderBinder.isUploading(any(), any()) } returns false | ||
| every { mockComponentsGetter.fileUploaderHelper } returns mockFileUploaderBinder | ||
| every { mockFileDownloadProgressListener.isDownloading(any(), any()) } returns false |
Collaborator
Author
There was a problem hiding this comment.
isDownloading left over from foreground services no need this since worker is used
alperozturk96
commented
Jun 11, 2026
| @Suppress("MagicNumber") | ||
| fun prepareForStart(operation: DownloadFileOperation) { | ||
| currentOperationTitle = File(operation.savePath).name | ||
| currentOperationTitle = operation.file.fileName |
Collaborator
Author
There was a problem hiding this comment.
Uses file name
alperozturk96
commented
Jun 11, 2026
| @Suppress("MagicNumber") | ||
| fun updateDownloadProgress(percent: Int, totalToTransfer: Long) { | ||
| // If downloads are so fast, no need to notify again. | ||
| if (percent == lastPercent) { |
Collaborator
Author
There was a problem hiding this comment.
Already outer call have this
alperozturk96
commented
Jun 11, 2026
| private suspend fun trySetForeground(filename: String) { | ||
| try { | ||
| val foregroundInfo = createWorkerForegroundInfo() | ||
| val foregroundInfo = createWorkerForegroundInfo(filename) |
Collaborator
Author
There was a problem hiding this comment.
Fixes empty notification
Open
4 tasks
Open
4 tasks
Collaborator
Author
|
/backport to stable-34.0.x |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://github.com/nextcloud/android/actions/runs/27345115706/artifacts/7569119183 |
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes