fix(manifest): Move camera2 feature declaration to scan-enabled flavors

[joshtrichards]

Moving to flavor-specific manifests to avoid warning about tools:node="replace" for builds that don't have scanning/camera2

Eliminates this check (lint) warning:

> Task :app:processGenericDebugMainManifest
/home/runner/work/android/android/app/src/debug/AndroidManifest.xml Warning:
	uses-feature#android.hardware.camera2 was tagged at AndroidManifest.xml:0 to replace another declaration but no other declaration present

• Tests written, or not not needed

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16468.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[AndyScherzinger]

Hi @joshtrichards @alperozturk96 since we have a general upload Pic via cam in the fab's bottom sheet I would have expected that it is needed in all flavors. Or are we using something else there?

[joshtrichards]

@AndyScherzinger I checked the upload-via-camera path: it uses the system camera app via ACTION_IMAGE_CAPTURE / ACTION_VIDEO_CAPTURE, so it doesn't use Camera2. The manifest override is only for the scanning dependency, which declares camera2 as required in scan-enabled flavors.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	32	32
Correctness	66	66
Dodgy code	213	213
Experimental	1	1
Malicious code vulnerability	2	2
Multithreaded correctness	29	29
Performance	41	41
Security	19	19
Total	403	403

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/29397778752/artifacts/8337173142
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16468-IT-master-10-54