ship harp also for manual-install and helm - #8370
Merged
Merged
Conversation
Signed-off-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/ship-harp-manual-install
branch
from
June 24, 2026 10:47
9ea0798 to
c40cb1c
Compare
szaimen
commented
Jun 24, 2026
szaimen
commented
Jun 24, 2026
21 tasks
When harp syncs over from the manual-install to the helm chart it needs the Kubernetes backend (HP_K8S_*) instead of the docker backend. The update-helm script now injects these env vars into the harp deployment, templated to values.yaml, and the chart readme documents them. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Simon L. <szaimen@e.mail.de>
…liases docs - Remove HARP_K8S_BEARER_TOKEN_FILE: HaRP already defaults it to the in-cluster service account token path, so templating it added nothing. - Add HARP_SERVICE_ACCOUNT_NAME so the harp pod can run under a service account the user grants the required RBAC to, and document the setup. - Correct the HARP_K8S_HOST_ALIASES docs: it is a comma-separated list of hostname:ip pairs, not JSON. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
changed the title
szaimen
commented
Jun 24, 2026
24 tasks
26 tasks
29 tasks
szaimen
added
3. to review
szaimen
marked this pull request as ready for review
August 4, 2026 11:32
szaimen
force-pushed
the
enh/noid/ship-harp-manual-install
branch
2 times, most recently
from
August 4, 2026 11:39
19d8e5e to
4780933
Compare
Signed-off-by: Simon L. <szaimen@e.mail.de>
This reverts commit c40cb1c. Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/ship-harp-manual-install
branch
from
August 4, 2026 11:40
4780933 to
553ce89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.