fix: stop using deprecated IAppContainer::getServer() - #2804
Merged
Conversation
Signed-off-by: Anna Larch <anna@nextcloud.com>
blizzz
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App::getContainer()is now typed as returningPsr\Container\ContainerInterfaceinstead of the deprecatedIAppContainer(nextcloud/server@1d55835d39, "refactor: Remove most usages of IAppContainer and IServerContainer"), so psalm flags->getServer()as undefined on the narrower type in current Renovate PRs bumpingnextcloud/ocp.getServer()has been deprecated since Nextcloud 20 anyway, and the app container'sget()already resolves core/server services directly (same pattern used throughoutDIContaineritself), so it was redundant.registerActivityConsumer()andregisterNotifier()with direct$c->get(...)/$this->getContainer()->get(...)calls.Test plan
composer update nextcloud/ocp --with-dependenciesto pull the same OCP commit CI uses, thencomposer run psalm— no errors (previously 3UndefinedInterfaceMethod/MissingPureAnnotationerrors ongetServer())