fix(notification): missing notification

[luka-nextcloud]

• Resolves: No push notifications for Deck deck#6899

[cypress]

Activity    Run #2853

Run Properties:   Failed #2853  •  55e39447b7: fix(notification): missing notification

Project	Activity
Branch Review	fix-missing-push-notifications
Run status	Failed #2853
Run duration	02m 13s
Commit	55e39447b7: fix(notification): missing notification
Committer	Luka Trovic
View all properties for this run ↗︎

---

Test results
Failures	1
Flaky	0
Pending	0
Skipped	0
Passing	9
View all changes introduced in this branch ↗︎

---

Tests for review

  cypress/e2e/sidebar.cy.ts • 1 failed test • Run E2E

View Output

Test		Artifacts
Check activity listing in the sidebar > Has share activity		Test Replay Screenshots

[nickvergessen]

This feels wrong/unexpected to change like that after 5 years of working like that?
The activity app takes care of parsing those notifications. If you don't want that, disable the option to receive activities as notifications for your type and handle the notifications in your app directly?

For now a similar result should be achievable by changing:
https://github.com/nextcloud/deck/blob/main/lib/Notification/Notifier.php#L80

if ($notification->getApp() !== 'deck' || $notification->getObjectType() === 'activity_notification') {

[luka-nextcloud]

@nickvergessen I do want the Activity app to handle parsing those notifications. However, for now, it won’t parse notifications where $notification->getApp() returns deck (different from activity)

[nickvergessen]

The activity app already handles them, it's not caring about the app id in the notification, only about the object type: https://github.com/nextcloud/activity/blob/master/lib/NotificationGenerator.php#L107
It helps a bit to be able to see which app's activity is causing notifications 🙈

[luka-nextcloud]

Now I understand what you mean, thank you.