fix: normalize spaced pre-release suffix in version.php check - #110
Merged
Conversation
version.php exposes betas/alphas as "35.0.0 beta 4" (spaces around the suffix and its number), but the release tag is contiguous "35.0.0beta4". The old sed only stripped a contiguous suffix, so the two never collapsed to the same bare version and the build init step failed with "version.php says 35.0.0 beta 4 but releasing 35.0.0beta4". Normalize by lowercasing, dropping all whitespace, then stripping the suffix, so both forms reduce to "x.y.z" before comparison. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP — AI-assisted draft, human to review/own before merge.
Take over from here.