Skip to content

fix(NcEllipsisedOption): make sure accessible name is properly computed #8670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
susnux wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −0
Open

fix(NcEllipsisedOption): make sure accessible name is properly computed #8670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/NcEllipsisedOption/NcEllipsisedOption.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,16 @@ export default {

<template>
<span dir="auto" class="name-parts" :title="name">
<span class="hidden-visually" v-text="name" />
<NcHighlight
aria-hidden="true"
class="name-parts__first"
:text="part1"
:search="search"
:highlight="highlight1" />
<NcHighlight
v-if="part2"
aria-hidden="true"
class="name-parts__last"
:text="part2"
:search="search"
Expand Down
25 changes: 25 additions & 0 deletions tests/component/components/NcSelect.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/**
* SPDX-FileCopyrightText: Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import { expect, test } from '@playwright/experimental-ct-vue'
import NcSelect from '../../../src/components/NcSelect/NcSelect.vue'

/**
* Previously due to NcEllipsedOption long option names
* were shown as "Verylongo ptionname" due to whitespace between <span> elements.
*/
test('Options have proper accessible names', async ({ mount, page }) => {
const component = await mount(NcSelect, {
props: {
options: ['Short', 'Verylongoptionnamethatlikelyoverflows'],
},
})

await expect(component.getByRole('combobox')).toBeVisible()
await component.getByRole('combobox').fill('Very')

console.error(await page.getByRole('option', { name: /Veryl/ }).innerHTML())
await expect(page.getByRole('option', { name: 'Verylongoptionnamethatlikelyoverflows' })).toBeVisible()
})
Loading