Ii updates readme and tests - #8
Open
iltoningui wants to merge 2 commits into
Open
Conversation
Contributor
|
@iltoningui The idea looks cool but the tests fail for this PR. Please fix so that all tests can pass. |
smaziano
requested changes
Mar 2, 2020
smaziano
left a comment
smaziano
left a comment
Contributor
There was a problem hiding this comment.
@iltoningui are fixing this any time soon ?
| return null; | ||
| } | ||
|
|
||
| public T fromJson(String body, Class<T> clazz) throws IOException { |
Contributor
There was a problem hiding this comment.
@iltoningui even though we discussed this over the "corridor" I believe you should've explained the reason for the change.
| public T fromJson(String body, Class<T> clazz) throws IOException { | ||
| public T fromJson(String body) throws IOException { | ||
| @SuppressWarnings("unchecked") | ||
| Class<T> clazz = (Class<T>) ((ParameterizedType) getClass().getGenericSuperclass()).getActualTypeArguments()[0]; |
Contributor
There was a problem hiding this comment.
This naming convention for the class to "clazz" never sounds right, it resonates nothing to me. What you think of something more meaningful such as "Resource" or "Entity" or other...?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.