Deprecate - #11
Conversation
📝 WalkthroughWalkthroughThe README is updated with a deprecation notice replacing the previous beta development disclaimer. The notice explains that starting with Newton 1.3, actuators are created exclusively from ChangesDocumentation Deprecation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
4-7: ⚡ Quick winClarify the supported compatibility window in the deprecation notice.
Please add one explicit sentence for legacy users (e.g., “Use this package only with Newton versions below 1.3”). Right now, the deprecation block and the remaining install/usage sections can read as conflicting guidance.
Proposed wording tweak
> **⚠️ Deprecation Notice:** Starting with [Newton](https://github.com/newton-physics/newton) 1.3, actuators are created in and used exclusively from Newton's built-in `newton.actuators` module. This standalone `newton-actuators` package will no longer be maintained. Please migrate: +> For legacy projects on Newton < 1.3, this package remains usable as-is, but no further updates are planned. > > - Concepts guide: https://newton-physics.github.io/newton/latest/concepts/actuators.html > - API reference: https://newton-physics.github.io/newton/latest/api/newton_actuators.html🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 4 - 7, Update the deprecation block in README.md to explicitly state the supported compatibility window by adding a short sentence such as “Use this package only with Newton versions below 1.3.”; reference the existing deprecation text that mentions Newton 1.3 and newton.actuators and append the compatibility clarification so readers know the standalone newton-actuators package is only for legacy Newton <1.3 users.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@README.md`:
- Around line 4-7: Update the deprecation block in README.md to explicitly state
the supported compatibility window by adding a short sentence such as “Use this
package only with Newton versions below 1.3.”; reference the existing
deprecation text that mentions Newton 1.3 and newton.actuators and append the
compatibility clarification so readers know the standalone newton-actuators
package is only for legacy Newton <1.3 users.
Summary by CodeRabbit
newton.actuatorslocation with updated migration guidance provided.