feat(nrdot-mssql): Added the automation cli for mssql otel - #1403
Open
RamanaReddy8801 wants to merge 32 commits into
Open
feat(nrdot-mssql): Added the automation cli for mssql otel#1403RamanaReddy8801 wants to merge 32 commits into
RamanaReddy8801 wants to merge 32 commits into
Conversation
…ation, SQL Server version gate)
RamanaReddy8801
marked this pull request as draft
July 21, 2026 06:18
RamanaReddy8801
marked this pull request as ready for review
July 31, 2026 06:44
Nandu-pns
reviewed
Aug 5, 2026
Nandu-pns
reviewed
Aug 5, 2026
Nandu-pns
reviewed
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://new-relic.atlassian.net/browse/NR-595317
Description: Implementation of the New Relic CLI installer for MSSQL OpenTelemetry (OTel) monitoring.
I’ve attached the test [documentation] covering several key integration scenarios for your review.
CI test coverage (Windows)
Added
test/definitions/nrdot/mssql-otel/mssql-windows2019.jsonto testnrdot-collector-mssqlon Windows (SQL-auth mode) — this is the firstNRDOT recipe with Windows CI coverage in the repo.
Two supporting changes were needed to make this possible:
test/deploy/windows/nrdot-mssql/install/roles/configure:the only SQL Server AMI available in CI ships with
sadisabled andWindows-Auth-only mode. This role switches SQL Server to Mixed Mode,
restarts it, then enables and sets a known
sapassword so therecipe's SQL-auth path (
NR_CLI_MSSQL_AUTH_MODE=1) can be tested.test/deploy/windows/newrelic-cli/install-recipe/roles/onafterstart/tasks/main.yml:added a generic
env_varpassthrough (PowerShell$env:assignments),matching the mechanism the Linux test runner already has. Without it,
there was no way to inject the recipe's
NR_CLI_MSSQL_*inputVars intoa Windows test at all. This is additive (
when: env_var is defined) anddoesn't affect any existing Windows test definition.