Skip to content

fix: Update APT repo configuration steps in dotnet linux recipe - #1227

Merged
shashank-reddy-nr merged 1 commit into
newrelic:forked-PRsfrom
nr-ahemsath:dotnet-agent-update-apt-instructions
Jun 25, 2025
Merged

fix: Update APT repo configuration steps in dotnet linux recipe#1227
shashank-reddy-nr merged 1 commit into
newrelic:forked-PRsfrom
nr-ahemsath:dotnet-agent-update-apt-instructions

Conversation

@nr-ahemsath

@nr-ahemsath nr-ahemsath commented Jun 23, 2025

Copy link
Copy Markdown
Member

This PR updates the .NET agent Linux install recipe to use a new public signing key and also replace the use of apt-key add (which is deprecated) with the current best practice of saving the key to a specific file and configuring the APT repo definition to be signed by that file.

Note: this is in draft status until the .NET agent does it's next release, which we plan to do early this week.

@nr-ahemsath nr-ahemsath mentioned this pull request Jun 24, 2025
Merged
@nr-ahemsath
nr-ahemsath marked this pull request as ready for review June 24, 2025 17:31
@nr-ahemsath

nr-ahemsath commented Jun 24, 2025

Copy link
Copy Markdown
Member Author

@shashank-reddy-nr Hi, this is Alex from the .NET agent team. I see that the CI for this PR is failing because I did it from a fork. However, I don't have permissions to push a branch directly to this repo. Can I get permissions to do that? Thanks.

@shashank-reddy-nr
shashank-reddy-nr changed the base branch from main to forked-PRs June 25, 2025 05:05
@shashank-reddy-nr shashank-reddy-nr changed the title Update APT repo configuration steps in dotnet linux recipe fix: Update APT repo configuration steps in dotnet linux recipe Jun 25, 2025
shashank-reddy-nr
shashank-reddy-nr approved these changes Jun 25, 2025
View reviewed changes

@shashank-reddy-nr shashank-reddy-nr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shashank-reddy-nr
shashank-reddy-nr merged commit ae31c7a into newrelic:forked-PRs Jun 25, 2025
6 of 9 checks passed
@shashank-reddy-nr

shashank-reddy-nr commented Jun 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hey @nr-ahemsath This repo has 90+ integration tests which will spin up EC2s always you change sometime in recipes. So, in-order to restrict integration tests to run without our notice, we only allow integration tests to run from non forked branches. As this repo is managed by self serve tool. If we want to add individuals to repos. Its not possible and we need to add your team as maintainers to repo. We generally add frequent contributors as maintainers to this repo using selfserve tool. So, we ask to raise pr to forked-PRs branch and we merge it directly, then we raise a PR to main branch from forked-PRs to main. I have raised a PR to main branch.
#1229

@shashank-reddy-nr shashank-reddy-nr mentioned this pull request Jun 25, 2025
Merged
shashank-reddy-nr added a commit that referenced this pull request Jul 3, 2025
@shashank-reddy-nr @nr-ahemsath
fix: Update APT repo config steps in dotnet linux recipe (#1227) (#1229)
ad88956 
Co-authored-by: Alex Hemsath <57361211+nr-ahemsath@users.noreply.github.com>
vagrawal-newrelic added a commit that referenced this pull request Jul 9, 2025
@vagrawal-newrelic @nr-ahemsath
@shashank-reddy-nr @spathlavath @Nandu-pns @pkudikyala @kkhandelwal-nr
feat: Added CLI changes for MySQL and Postgres RDS Query Performance …
ac21c2c 
…Monitoring (#1240)

* fix: Update APT repo configuration steps in dotnet linux recipe (#1227)

* feat: Added CLI changes for MySQL RDS Query Performance Monitoring (#1217)

* feat: Added minor enhancements to MySQL recipe (#1189)

* feat: Added minor enhancements to db query analysis

* fix: Empty commit

* fix: minor fixes

* fix: minor enhancements

* fix:Added minor enhancements

* fix:Added check for schema and store procedure creation

* feat: Added CLI changes for MySQL RDS Query Performance Monitoring

* feat: Added minor enhancements

* feat: Added minor enhancements

* feat: Removed duplicate file

* feat: Docs link update

* feat: fixed PROCEDURE enable_essential_consumers_and_instruments does not exist

* Revert "feat: Added minor enhancements to MySQL recipe (#1189)" (#1212)

This reverts commit 3bf473e.

* feat: Added processMatch

* feat: Added install targets and discoveryMode

---------

Co-authored-by: Pulipelly Shashank Reddy <spulipelly@newrelic.com>
Co-authored-by: Nandu-pns <100915954+Nandu-pns@users.noreply.github.com>
Co-authored-by: vagrawal-newrelic <vagrawal@newrelic.com>

* feat: Added Guided Install (CLI) for Postgres On-Host and RDS Query Monitoring(#1211)

* feat: Added Guided Install (CLI) for Postgres On-Host and RDS Query Monitoring

* fix: Updated RDS flag and config file

* fix: Added is_rds flag in the config file

* Removed OS versions regex

---------

Co-authored-by: vagrawal-newrelic <vagrawal@newrelic.com>

* feat: Add new eBPF Installation Recipe for Ubuntu (#1228)

* Initial commit - eBPF agent recipe

* Create default config file and minor bug fixes

* Add GPG key verification

* Set discoveryMode to targeted

* Remove test code

* Remove version 21 from platformVersion list

* Update postInstall info message

* Increase certificate expiry to 2 years

* Remove linux header installation task

* Remove unit test case

* Point APT source to production

---------

Co-authored-by: Pulipelly Shashank Reddy <spulipelly@newrelic.com>

* Revert "feat: Add new eBPF Installation Recipe for Ubuntu (#1228)" (#1244)

This reverts commit d6b1c69.

---------

Co-authored-by: Alex Hemsath <57361211+nr-ahemsath@users.noreply.github.com>
Co-authored-by: Pulipelly Shashank Reddy <spulipelly@newrelic.com>
Co-authored-by: spathlavath <spathlavath@newrelic.com>
Co-authored-by: Nandu-pns <100915954+Nandu-pns@users.noreply.github.com>
Co-authored-by: pkudikyala <105910179+pkudikyala@users.noreply.github.com>
Co-authored-by: Kapil Khandelwal <kkhandelwal@newrelic.com>
shashank-reddy-nr added a commit that referenced this pull request Jul 9, 2025
@shashank-reddy-nr @kkhandelwal-nr
feat: Add new eBPF Installation Recipe for Ubuntu (#1246)
540eb8d 
* fix: Update APT repo configuration steps in dotnet linux recipe (#1227)

* feat: Added CLI changes for MySQL RDS Query Performance Monitoring (#1217)

* feat: Added minor enhancements to MySQL recipe (#1189)

* feat: Added minor enhancements to db query analysis

* fix: Empty commit

* fix: minor fixes

* fix: minor enhancements

* fix:Added minor enhancements

* fix:Added check for schema and store procedure creation

* feat: Added CLI changes for MySQL RDS Query Performance Monitoring

* feat: Added minor enhancements

* feat: Added minor enhancements

* feat: Removed duplicate file

* feat: Docs link update

* feat: fixed PROCEDURE enable_essential_consumers_and_instruments does not exist

* Revert "feat: Added minor enhancements to MySQL recipe (#1189)" (#1212)

This reverts commit 3bf473e.

* feat: Added processMatch

* feat: Added install targets and discoveryMode

---------

Co-authored-by: Pulipelly Shashank Reddy <spulipelly@newrelic.com>
Co-authored-by: Nandu-pns <100915954+Nandu-pns@users.noreply.github.com>
Co-authored-by: vagrawal-newrelic <vagrawal@newrelic.com>

* feat: Added Guided Install (CLI) for Postgres On-Host and RDS Query Monitoring(#1211)

* feat: Added Guided Install (CLI) for Postgres On-Host and RDS Query Monitoring

* fix: Updated RDS flag and config file

* fix: Added is_rds flag in the config file

* Removed OS versions regex

---------

Co-authored-by: vagrawal-newrelic <vagrawal@newrelic.com>

* feat: Add new eBPF Installation Recipe for Ubuntu (#1228)

* Initial commit - eBPF agent recipe

* Create default config file and minor bug fixes

* Add GPG key verification

* Set discoveryMode to targeted

* Remove test code

* Remove version 21 from platformVersion list

* Update postInstall info message

* Increase certificate expiry to 2 years

* Remove linux header installation task

* Remove unit test case

* Point APT source to production

---------

Co-authored-by: Pulipelly Shashank Reddy <spulipelly@newrelic.com>

* Revert "feat: Add new eBPF Installation Recipe for Ubuntu (#1228)" (#1244)

This reverts commit d6b1c69.

* feat: Add new eBPF Installation Recipe for Ubuntu (#1245)

* Initial commit - eBPF agent recipe

* Create default config file and minor bug fixes

* Add GPG key verification

* Set discoveryMode to targeted

* Remove test code

* Remove version 21 from platformVersion list

* Update postInstall info message

* Increase certificate expiry to 2 years

* Remove linux header installation task

* Remove unit test case

* Point APT source to production

---------

* Update OTLP_ENDPOINT dynamically based on environment

---------
Co-authored-by: Kapil Khandelwal <kkhandelwal@newrelic.com>
kkhandelwal-nr added a commit to kkhandelwal-nr/temp-open-install-library that referenced this pull request Jul 10, 2025
@shashank-reddy-nr @kkhandelwal-nr
feat: Add new eBPF Installation Recipe for Ubuntu (newrelic#1246)
49e36c0 
* fix: Update APT repo configuration steps in dotnet linux recipe (newrelic#1227)

* feat: Added CLI changes for MySQL RDS Query Performance Monitoring (newrelic#1217)

* feat: Added minor enhancements to MySQL recipe (newrelic#1189)

* feat: Added minor enhancements to db query analysis

* fix: Empty commit

* fix: minor fixes

* fix: minor enhancements

* fix:Added minor enhancements

* fix:Added check for schema and store procedure creation

* feat: Added CLI changes for MySQL RDS Query Performance Monitoring

* feat: Added minor enhancements

* feat: Added minor enhancements

* feat: Removed duplicate file

* feat: Docs link update

* feat: fixed PROCEDURE enable_essential_consumers_and_instruments does not exist

* Revert "feat: Added minor enhancements to MySQL recipe (newrelic#1189)" (newrelic#1212)

This reverts commit 3bf473e.

* feat: Added processMatch

* feat: Added install targets and discoveryMode

---------

Co-authored-by: Pulipelly Shashank Reddy <spulipelly@newrelic.com>
Co-authored-by: Nandu-pns <100915954+Nandu-pns@users.noreply.github.com>
Co-authored-by: vagrawal-newrelic <vagrawal@newrelic.com>

* feat: Added Guided Install (CLI) for Postgres On-Host and RDS Query Monitoring(newrelic#1211)

* feat: Added Guided Install (CLI) for Postgres On-Host and RDS Query Monitoring

* fix: Updated RDS flag and config file

* fix: Added is_rds flag in the config file

* Removed OS versions regex

---------

Co-authored-by: vagrawal-newrelic <vagrawal@newrelic.com>

* feat: Add new eBPF Installation Recipe for Ubuntu (newrelic#1228)

* Initial commit - eBPF agent recipe

* Create default config file and minor bug fixes

* Add GPG key verification

* Set discoveryMode to targeted

* Remove test code

* Remove version 21 from platformVersion list

* Update postInstall info message

* Increase certificate expiry to 2 years

* Remove linux header installation task

* Remove unit test case

* Point APT source to production

---------

Co-authored-by: Pulipelly Shashank Reddy <spulipelly@newrelic.com>

* Revert "feat: Add new eBPF Installation Recipe for Ubuntu (newrelic#1228)" (newrelic#1244)

This reverts commit d6b1c69.

* feat: Add new eBPF Installation Recipe for Ubuntu (newrelic#1245)

* Initial commit - eBPF agent recipe

* Create default config file and minor bug fixes

* Add GPG key verification

* Set discoveryMode to targeted

* Remove test code

* Remove version 21 from platformVersion list

* Update postInstall info message

* Increase certificate expiry to 2 years

* Remove linux header installation task

* Remove unit test case

* Point APT source to production

---------

* Update OTLP_ENDPOINT dynamically based on environment

---------
Co-authored-by: Kapil Khandelwal <kkhandelwal@newrelic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shashank-reddy-nr shashank-reddy-nr shashank-reddy-nr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nr-ahemsath @shashank-reddy-nr