chore: Set ignoreApdex warning log to trace-level - #4188
Merged
amychisholm03 merged 1 commit intoJul 31, 2026
Merged
Conversation
amychisholm03
force-pushed
the
NR-4187/remove-ignoreApdex-warning-logs
branch
from
July 31, 2026 18:36
2efd386 to
9cbac83
Compare
amychisholm03
changed the title
ignoreApdex warning logignoreApdex warning log to trace-level
bizob2828
approved these changes
Jul 31, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4188 +/- ##
==========================================
- Coverage 97.52% 97.44% -0.09%
==========================================
Files 522 522
Lines 62927 62927
Branches 1 1
==========================================
- Hits 61371 61320 -51
- Misses 1556 1607 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-project-automation
Bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When users set
ignoreApdex: true, they get a warning log that Apdex is disabled for every transaction. This is unhelpful because they already know that and the warnings can pollute our logs. This PR changes it only appear when trace-level logs are enabled.How to Test
There were no tests asserting this warning log was present.
Related Issues
Closes #4187