Skip to content

chore: Fixed v22 in versioned tests CI - #4071

Merged
jsumners-nr merged 1 commit into
mainfrom
ci-fix
Jun 25, 2026
Merged

chore: Fixed v22 in versioned tests CI#4071
jsumners-nr merged 1 commit into
mainfrom
ci-fix

Conversation

@jsumners-nr

@jsumners-nr jsumners-nr commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

When I adjusted our workflow to get around a current runtime bug (#4070 (review)) I did not realize that the workflow is naming coverage files with the explicit version matrix strings. This caused the coverage tool to not find the corresponding coverage files. This PR fixes the problem.

Run https://github.com/newrelic/node-newrelic/actions/runs/28195105982 shows it is all working.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.34%. Comparing base (c88d2b7) to head (f8c1c51).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4071      +/-   ##
==========================================
+ Coverage   90.06%   97.34%   +7.28%     
==========================================
  Files         501      514      +13     
  Lines       59885    61740    +1855     
  Branches        1        1              
==========================================
+ Hits        53934    60102    +6168     
+ Misses       5951     1638    -4313     
Flag Coverage Δ
integration-tests-cjs-22.22.3 73.64% <ø> (?)
integration-tests-cjs-22.x ?
integration-tests-cjs-24.16.0 74.25% <ø> (?)
integration-tests-cjs-24.x ?
integration-tests-esm-22.22.3 54.00% <ø> (?)
integration-tests-esm-22.x ?
integration-tests-esm-24.16.0 55.17% <ø> (?)
integration-tests-esm-24.x ?
unit-tests-22.22.3 89.09% <ø> (?)
unit-tests-22.x ?
unit-tests-24.16.0 89.09% <ø> (?)
unit-tests-24.x ?
versioned-tests-22.22.3 80.41% <ø> (?)
versioned-tests-24.16.0 79.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsumners-nr
jsumners-nr marked this pull request as ready for review June 25, 2026 19:51
@jsumners-nr
jsumners-nr merged commit 527e9d0 into main Jun 25, 2026
57 of 59 checks passed
@jsumners-nr
jsumners-nr deleted the ci-fix branch June 25, 2026 19:54
@github-project-automation github-project-automation Bot moved this from Needs PR Review to Done: Issues recently completed in Node.js Engineering Board Jun 25, 2026
@github-actions github-actions Bot mentioned this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done: Issues recently completed

Development

Successfully merging this pull request may close these issues.

3 participants