Skip to content

fix(alerts): fix incorrect delete endpoint for multilocation alert conditions - #1315

Draft
pranav-new-relic wants to merge 1 commit into
mainfrom
forked-PRs
Draft

fix(alerts): fix incorrect delete endpoint for multilocation alert conditions#1315
pranav-new-relic wants to merge 1 commit into
mainfrom
forked-PRs

Conversation

@pranav-new-relic

@pranav-new-relic pranav-new-relic commented Jun 25, 2025

Copy link
Copy Markdown
Member

…nditions (#1314)

fix(alerts): fix incorrect delete endpoint for multilocation alert conditions (#1314)
@codecov-commenter

codecov-commenter commented Jun 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@81626a4). Learn more about missing BASE report.
⚠️ Report is 106 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1315   +/-   ##
=======================================
  Coverage        ?   36.43%           
=======================================
  Files           ?      132           
  Lines           ?     7808           
  Branches        ?        0           
=======================================
  Hits            ?     2845           
  Misses          ?     4771           
  Partials        ?      192           
Flag Coverage Δ
integration 5.49% <0.00%> (?)
unit 35.79% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pranav-new-relic

Copy link
Copy Markdown
Member Author

All good with the integration tests and stuff too, so this shouldn't be a problem.
Double checking a few things with Jeremy before I go ahead and merge.

@nr-developer-toolkit

Copy link
Copy Markdown
Contributor

@nr-developer-toolkit @pranav-new-relic do not merge right now

@pranav-new-relic

Copy link
Copy Markdown
Member Author

The outcome of a very insightful conversation with: @jstorerNR - we'll move forward with this PR once he has the change to handle traffic to the older alerts_conditions DELETE endpoint (caused by older versions of the client consumed by older versions of the New Relic Terraform Provider) worked around/handled in the new service they're moving to

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants