feat(alerts): add support for cci polling frequency field in conditions - #1303
feat(alerts): add support for cci polling frequency field in conditions#1303gffuentes wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1303 +/- ##
=======================================
Coverage ? 36.85%
=======================================
Files ? 132
Lines ? 7808
Branches ? 0
=======================================
Hits ? 2878
Misses ? 4734
Partials ? 196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4739360 to
47121b6
Compare
| AggregationDelay *int `json:"aggregationDelay"` | ||
| AggregationTimer *int `json:"aggregationTimer"` | ||
| SlideBy *int `json:"slideBy"` | ||
| PollingFrequency *int `json:"pollingFrequency,omitempty"` |
There was a problem hiding this comment.
PollingFrequency should be nullable, right? Curious if we should leave off omitEmpty here.
There was a problem hiding this comment.
PollingFrequency is only for static conditions, but alertsNrqlConditionBaselineCreate does allow for pollingFrequency: null.
There was a problem hiding this comment.
i fixed this - looks like create should allow null, but update should not
47121b6 to
a06d530
Compare
a06d530 to
02f8af5
Compare
|
|
DO NOT MERGE YET
https://new-relic.atlassian.net/browse/NR-413526
Adds support for polling frequency - a new field on conditions that is part of CCI project
newrelic/terraform-provider-newrelic#2890