fix: remove false-positive HTTPS_PROXY warning when HTTPS_PROXY is already set - #1839
Open
pranav-new-relic wants to merge 1 commit into
Open
fix: remove false-positive HTTPS_PROXY warning when HTTPS_PROXY is already set#1839pranav-new-relic wants to merge 1 commit into
pranav-new-relic wants to merge 1 commit into
Conversation
pranav-new-relic
force-pushed
the
fix/https-proxy-false-positive-warning
branch
from
May 5, 2026 11:14
55a75ac to
48dfa5f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1839 +/- ##
==========================================
+ Coverage 31.30% 31.32% +0.01%
==========================================
Files 181 181
Lines 12551 12588 +37
==========================================
+ Hits 3929 3943 +14
- Misses 8478 8504 +26
+ Partials 144 141 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ready set The previous condition used string matching to detect whether HTTPS_PROXY was set to an http:// URL and warned the user — but HTTPS_PROXY=http://... is a valid and working configuration (the HTTPS in the var name refers to the proxied traffic type, not the proxy connection scheme). The warning now only fires when HTTP_PROXY is set but HTTPS_PROXY is absent, which is the actual misconfiguration the message was intended to flag. Fixes NR-560830 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pranav-new-relic
force-pushed
the
fix/https-proxy-false-positive-warning
branch
from
May 5, 2026 11:30
48dfa5f to
260a099
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTPS_PROXYwas already set with anhttp://URL (e.g.HTTPS_PROXY=http://localhost:8080)HTTPS_PROXYcontained"http"but not"https", which matches anyhttp://URLHTTP_PROXYis set butHTTPS_PROXYis absent (the actual misconfiguration the message was meant to flag)TestProxyNetwork(which only calledt.Log) withTestProxyWarningCondition, which covers all four cases with real assertionsTest plan
go test -tags unit ./internal/install/ -run TestProxyWarningCondition -v— all 4 subtests passHTTPS_PROXY=http://localhost:8080and run guided install — warning should no longer appearHTTP_PROXY=http://localhost:8080(noHTTPS_PROXY) and run guided install — warning should still appearFixes NR-560830 — resolved via AI (Claude Code / Claude Sonnet 4.6)
🤖 Generated with Claude Code