chore: try and update release.yml - #1756
Conversation
|
@copilot it looks like in the release workflow we have, the command where we try to publish a version of the CLI to AWS to the S3 bucket at download.newrelic.com is directly being executed, without a check performed at the beginning of the workflow to evaluate if the credentials we're using AWS with in the workflow has necessary permissions to be able to push to the S3 bucket. Because this is not in the beginning, the release artifacts are first being published to GitHub, only to realise at the end that the push to AWS is not working, which has caused us to revert the changelog changes and artifacts released on GitHub for inconsistency. To avoid this problem, can you add a permission check at the beginning of the workflow to make sure that the command to push to s3 has the right permissions, and if it does not, stop the release workflow? |
|
@pranav-new-relic I've opened a new pull request, #1757, to work on those changes. Once the pull request is ready, I'll request review from you. |
No description provided.