feat: expose 'nr-path:agent_dir' when expanding values - #2783
Merged
Conversation
sigilioso
force-pushed
the
feat/expose-filesystem-path
branch
from
August 6, 2026 13:10
e062f72 to
d6af80e
Compare
sigilioso
force-pushed
the
feat/expose-filesystem-path
branch
from
August 6, 2026 13:19
d6af80e to
e4da4af
Compare
sigilioso
force-pushed
the
feat/expose-filesystem-path
branch
from
August 6, 2026 15:11
e4da4af to
abea207
Compare
sigilioso
force-pushed
the
feat/expose-filesystem-path
branch
from
August 7, 2026 06:36
c25b421 to
ef54ff2
Compare
sigilioso
force-pushed
the
feat/expose-filesystem-path
branch
2 times, most recently
from
August 7, 2026 07:54
4fd8958 to
d69448c
Compare
gsanchezgavier
previously approved these changes
Aug 7, 2026
gsanchezgavier
left a comment
Contributor
There was a problem hiding this comment.
thanks! i'm not sure how is the current docs about this , but it would be worth to check and document it
|
|
||
| let (variable_tree, runtime_config) = (agent_type.variables, agent_type.runtime_config); | ||
|
|
||
| // Expand user values |
Contributor
There was a problem hiding this comment.
nit: we could improve this comment with why we are expanding secrets and this var.
sigilioso
force-pushed
the
feat/expose-filesystem-path
branch
from
August 7, 2026 09:17
d69448c to
f0ec9be
Compare
gsanchezgavier
approved these changes
Aug 7, 2026
sigilioso
force-pushed
the
feat/expose-filesystem-path
branch
from
August 10, 2026 06:16
9b3cfd2 to
86df629
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes the new variable
${nr-path:agent_dir}when expanding user values. This allows referencing additional configuration files from a particular configuration in agent types.Example from the unit test:
agent-type:
values: