NR-575201: Add Trivy security scan and Dependabot config - #248
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
satya-nr
marked this pull request as ready for review
July 17, 2026 09:25
skothuri-nr
reviewed
Jul 20, 2026
| @@ -28,767 +28,374 @@ | |||
| "junit-report-merger": "^6.0.2" | |||
| } | |||
| }, | |||
| "node_modules/@aws-crypto/crc32": { | |||
Contributor
There was a problem hiding this comment.
why only package-lock.json is updated without package.json?
Contributor
Author
There was a problem hiding this comment.
All the versions in package.json has caret symbol (^) whicjh permits minor and patch updates, so by there is no need to update package.json simply we are doing npm update which updates next minor versions in package-lock.json.
- Enable Trivy misconfig scanner (Terraform IaC coverage) - Exclude node_modules from scan (third-party Dockerfiles are noise) - Pin versions/requirements.txt (PyYAML, requests) so Trivy/Dependabot can track them - Add pip and terraform ecosystems to Dependabot (existing dirs)
skothuri-nr
approved these changes
Jul 21, 2026
maya-jha
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds standard security scanning to this repo. Ticket: NR-575201.
main, uploads SARIF to Security → Code scanning.github-actions+npm(covers bothtest-suiteandcontroller-scriptspackage.json).#logging-integrations-notificationsviaSLACK_TRIVY_WEBHOOK_URL.trivy-imagejob — this repo has no Dockerfile, so nothing to build/scan.Files
.github/dependabot.yml.github/workflows/security_scan_pr_schedule.yamlintegration-tests/controller-scripts/package-lock.jsonnpm updatePrerequisite
SLACK_TRIVY_WEBHOOK_URLrepo secret added.Test plan
fsscan locally — surfaced 9 HIGH/CRITICAL CVEs incontroller-scripts/package-lock.json, fixed vianpm update, rescanned locally → 0 findings.curl— messages land correctly in#logging-integrations-notifications(both Trivy alert and Dependabot notify formats).Tested locally: ran strategyMatrix.py with pinned vs unpinned deps of requirements.txt in isolated venvs — outputs are byte-identical, so pinning has zero behavior impact on the build matrix.