Skip to content

Replicaset namespace relationship - #3119

Merged
mborroni merged 3 commits into
newrelic:mainfrom
codylawson:replicaset-namespace-relationship
Aug 4, 2026
Merged

mborroni merged 3 commits into
newrelic:mainfrom
codylawson:replicaset-namespace-relationship

Conversation

@codylawson

Copy link
Copy Markdown
Contributor

Relevant information

Adding replicaset <> namespace relationship file with updated condition to filter more entities.

❓ One question that this may raise is using the regex condition matcher with an attribute that is a number. Is this approach valid or can regex only be used with string attributes?

Api Review Board (ARB)

ARB Jira ticket:
https://new-relic.atlassian.net/browse/NR-541144

Business justification doc: https://newrelic.atlassian.net/wiki/spaces/KOT/pages/5297407012/Business+Justification+for+K8s+Entities+relationships

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.
  • I've linked an ARB ticket & received approval from API Review Board in order to make these changes

nr-codylawson and others added 2 commits August 3, 2026 13:29
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Excludes scaled-to-zero ReplicaSets (podsDesired=0) from the NRI-based
rule, which account for over half of matched K8sReplicasetSample events
in sampled data - these are historical rollout artifacts with no live
pods and don't need a continuously-refreshed namespace edge.

Also fixes the OTel rule's source resolver from lookupGuid to buildGuid
to match the Deployment/DaemonSet/StatefulSet sibling rules, removing an
unnecessary candidate-search lookup on every matched event.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot
entityBot requested a review from a team August 3, 2026 20:24
@codylawson
codylawson marked this pull request as draft August 3, 2026 20:24
@mborroni

mborroni commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

❓ One question that this may raise is using the regex condition matcher with an attribute that is a number. Is this approach valid or can regex only be used with string attributes?

The engine converts everything to strings before any condition evaluation occurs so regex conditions work on numeric attributes.

@codylawson
codylawson marked this pull request as ready for review August 4, 2026 14:51

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@mborroni
mborroni merged commit 6df0d65 into newrelic:main Aug 4, 2026
4 checks passed
mborroni added a commit that referenced this pull request Aug 4, 2026
mborroni added a commit that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants