Skip to content

Rename EXT_PORT entity name - #3109

Merged
mborroni merged 26 commits into
newrelic:mainfrom
faltimiras:alti/npm-topology
Aug 3, 2026
Merged

mborroni merged 26 commits into
newrelic:mainfrom
faltimiras:alti/npm-topology

Conversation

@faltimiras

@faltimiras faltimiras commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Use deviceName:Port as name as well as it is more descriptive

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.
  • I've linked an ARB ticket & received approval from API Review Board in order to make these changes

entityBot
entityBot previously approved these changes Jul 30, 2026

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot
entityBot requested a review from a team July 30, 2026 13:31
@entityBot

Copy link
Copy Markdown
Collaborator

⚠️ Review Required ⚠️

👋 This PR has seen no activity in over 3 days and is still awaiting approval from: @newrelic/NETPERFMON

Please review or provide an update.

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • Failed to parse relationship synthesis - Exception: Source NetworkTopology is not an allowed source. Possible values are APM Metrics, Infrastructure Agent, Kubernetes Integration, AWS Integration, GCP Integration, Azure Integration, OnHost Integration, OpenTelemetry, Pixie, Prometheus, Distributed Tracing, Metric API, Event API, AIOPS, Browser Monitoring, Mobile Monitoring, Network Monitoring
  • We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

entityBot
entityBot previously approved these changes Aug 3, 2026

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

entityBot
entityBot previously approved these changes Aug 3, 2026

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.

@mborroni
mborroni merged commit 59dd6ee into newrelic:main Aug 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants