Fix absinthe subscription regsitration#566
Merged
Merged
Conversation
binaryseed
force-pushed
the
absinthe-operation-fix
branch
from
4fc7887 to
44dd866
Compare
binaryseed
commented
Jun 30, 2026
Comment on lines
+86
to
+90
| emitter = | ||
| case meta.blueprint.execution.result do | ||
| %{emitter: emitter} -> emitter | ||
| _ -> operation | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
fix: result isn't there for subscriptions, so protect against that
tpitale
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in handling the stop span from an Absinthe subscription registration operation.
Closes #561