Finished with some UI improvements to the editor - #167
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9636d44d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| layout->addWidget(toolbar); | ||
|
|
||
| model = new QFileSystemModel(this); | ||
| model->setIconProvider(&atlasFileIconProvider); |
There was a problem hiding this comment.
When the content browser populates any project directory, QFileSystemModel gathers file info on its worker thread; installing this provider makes that worker call AtlasFileIconProvider::icon(), which returns styling::icon(...) and renders QPixmaps with QPainter. Pixmap painting is GUI-thread-only, so browsing folders can produce thread-safety warnings or crash on some Qt platforms; prebuild/cache these icons on the GUI thread or avoid pixmap rendering in the provider.
Useful? React with 👍 / 👎.
| materialEditorPanel->openMaterial(path); | ||
| materialDock->toggleView(true); | ||
| materialDock->raise(); | ||
| activateWorkspace(1); |
There was a problem hiding this comment.
If the user has hidden the Workspace dock via the Window menu, double-clicking or creating a material now only switches the QStackedWidget index, but the material editor lives inside that hidden dock, so nothing becomes visible. The old path explicitly toggled and raised the material dock, and the new workspace menu actions do the same for the workspace dock; this asset activation path should also show/raise the Workspace dock before switching to Shading.
Useful? React with 👍 / 👎.
1 participant
No description provided.