Skip to content

Added a material editor - #164

Merged
maxvdec merged 5 commits into
editorfrom
feature/material-editor
Jul 16, 2026
Merged

Added a material editor#164
maxvdec merged 5 commits into
editorfrom
feature/material-editor

Conversation

@maxvdec

@maxvdec maxvdec commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@maxvdec maxvdec added this to the Alpha 9 milestone Jul 16, 2026
@maxvdec maxvdec added atlas Features or things related to the core renderer editor labels Jul 16, 2026
@maxvdec
maxvdec merged commit f7daf62 into editor Jul 16, 2026
9 checks passed
@maxvdec
maxvdec deleted the feature/material-editor branch July 16, 2026 15:08

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: acbf04beaf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread runtime/lib/context.cpp
if (auto *coreObject = dynamic_cast<CoreObject *>(&object);
coreObject != nullptr) {
coreObject->material = material.material;
coreObject->textures.clear();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset texture state when clearing material textures

When a textureless material is assigned to an object that previously had any texture, this clears the texture list but leaves CoreObject::useTexture set from the earlier attachTexture() call. The render path then still uploads useTexture=1 with textureCount=0, so the texture shader samples/divides with no bound textures instead of displaying the new solid material; reset the render flags for the no-texture path as well, including the model mesh branch.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

atlas Features or things related to the core renderer editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant