Added a material editor - #164
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: acbf04beaf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (auto *coreObject = dynamic_cast<CoreObject *>(&object); | ||
| coreObject != nullptr) { | ||
| coreObject->material = material.material; | ||
| coreObject->textures.clear(); |
There was a problem hiding this comment.
Reset texture state when clearing material textures
When a textureless material is assigned to an object that previously had any texture, this clears the texture list but leaves CoreObject::useTexture set from the earlier attachTexture() call. The render path then still uploads useTexture=1 with textureCount=0, so the texture shader samples/divides with no bound textures instead of displaying the new solid material; reset the render flags for the no-texture path as well, including the model mesh branch.
Useful? React with 👍 / 👎.
No description provided.