add highpass to basic tutorial#119
Closed
dominikwelke wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Hello @dominikwelke Thanks for the contribution. Don't hesitate to reopen the PR/ Issue if you think it is missing somewhere else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi GEDAI team
thanks for a great new tool to play around with!
I noticed in the python version you don't currently recommend the HP prior to denoising, as you do in the matlab/eeglab tutorial (https://github.com/neurotuning/GEDAI-master/wiki/Tutorials + baked in the GUI).
with all the recordings i tried this step was in fact critical, so here's a small PR if you want to add it.
cheers!