Skip to content

add highpass to basic tutorial#119

Closed
dominikwelke wants to merge 1 commit into
neurotuning:mainfrom
dominikwelke:tutorial-minor
Closed

add highpass to basic tutorial#119
dominikwelke wants to merge 1 commit into
neurotuning:mainfrom
dominikwelke:tutorial-minor

Conversation

@dominikwelke

Copy link
Copy Markdown

hi GEDAI team

thanks for a great new tool to play around with!

I noticed in the python version you don't currently recommend the HP prior to denoising, as you do in the matlab/eeglab tutorial (https://github.com/neurotuning/GEDAI-master/wiki/Tutorials + baked in the GUI).

with all the recordings i tried this step was in fact critical, so here's a small PR if you want to add it.

cheers!

@vferat

vferat commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Hello @dominikwelke

Thanks for the contribution.
We have been working on a big API refactor during the last few months and the change has already been included in another (PR #97 ).
You can see the change at : https://neurotuning.github.io/gedai/dev/generated/tutorials/use/00_gedai_offline_pipeline.html

Don't hesitate to reopen the PR/ Issue if you think it is missing somewhere else.

@vferat vferat closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants