Add the ability to disable the detach key with ZMX_NO_DETACH_KEY#189
Open
varun-qumulo wants to merge 1 commit into
Open
Add the ability to disable the detach key with ZMX_NO_DETACH_KEY#189varun-qumulo wants to merge 1 commit into
varun-qumulo wants to merge 1 commit into
Conversation
ctrl+\ as the detach key is hardcoded with no way to opt out, which conflicts with programs that use it themselves (e.g. vim's ctrl+\ ctrl+n to escape its own :terminal). Since the byte is intercepted in the client's input loop before it ever reaches the remote PTY, no remapping on the inner program's side can work around it. Setting ZMX_NO_DETACH_KEY (to any value) skips the ctrl+\ intercept so it passes through as normal input; zmx detach or closing the window still work as usual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use ctrl+\ ctrl+n in vim to escape its integrated terminal - this doesn't play nice with zmx.
This PR adds
ZMX_NO_DETACH_KEYwhich can be set to disable zmx'sctrl+\key handling.I tested this on
linux-x86_64with Ghostty.