fix(attach): reclaim leader on kitty keyboard input#144
Open
wegel wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #141.
#141 fixed the case where the daemon kept a stale leader fd after a client disconnected, but it explicitly left one remaining gap: non-leader input could still be ignored when libghostty rejected valid Kitty
CSI ukey sequences with colon subparameters.This patch handles that case directly in
isUserInput().Problem
When a non-leader client sends keyboard input like:
\x1b[102;1:1u\x1b[57444;1:1ulibghostty warns and does not classify the sequence as user input. As a result,
handleInput()treats the payload as non-user input and refuses to transfer leadership to the active client.In practice, that leaves a re-attached client unable to take control even though its input is reaching the daemon.
Fix
Recognize Kitty
CSI ukey sequences directly before falling back to the libghostty parser:CSI key-code[:alternates] ; modifiers[:event-type] [; text-codepoints] uThis keeps the change scoped to leader detection only. It does not change detach handling or terminal state restoration.
Test plan
zig build testzig build -Doptimize=ReleaseSafe --prefix ~/.localCSI ukeyboard input