Skip to content

Fix HRV tuple input handling - #1205

Open
Aman-Tripathi27 wants to merge 1 commit into
neuropsychology:masterfrom
Aman-Tripathi27:fix-hrv-tuple-input
Open

Fix HRV tuple input handling#1205
Aman-Tripathi27 wants to merge 1 commit into
neuropsychology:masterfrom
Aman-Tripathi27:fix-hrv-tuple-input

Conversation

@Aman-Tripathi27

@Aman-Tripathi27 Aman-Tripathi27 commented Sep 1, 2026

Copy link
Copy Markdown

Summary

  • support raw (peaks, sampling_rate) tuples without accessing missing metadata
  • support (signals, info) tuples returned by processing functions
  • add regression tests for both tuple input forms

Testing

  • python3 -m pytest -o addopts="" tests/tests_hrv.py -k "tuple_input or tuple_metadata_input" -q
  • python3 -m pytest -o addopts="" tests/tests_hrv.py -k "not hrv_missing and not hrv_rsa" -q

The focused tuple tests pass. The non-network HRV suite passes (15 tests); the two omitted tests download data at runtime.

@codecov-commenter

codecov-commenter commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.90%. Comparing base (ff419d9) to head (3c5cc11).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
+ Coverage   57.78%   57.90%   +0.12%     
==========================================
  Files         310      310              
  Lines       15680    15673       -7     
==========================================
+ Hits         9060     9076      +16     
+ Misses       6620     6597      -23     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pull-request-size pull-request-size Bot added size/M and removed size/S labels Sep 1, 2026
@Aman-Tripathi27 Aman-Tripathi27 changed the title Fix HRV tuple input without metadata Fix HRV tuple input handling Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants