[Fix] Forward custom amplitude_min through eda_process (#1197) - #1203
Open
SyedAshhadIbrar wants to merge 1 commit into
Open
[Fix] Forward custom amplitude_min through eda_process (#1197)#1203SyedAshhadIbrar wants to merge 1 commit into
SyedAshhadIbrar wants to merge 1 commit into
Conversation
Hardcoded amplitude_min=0.1 prevented a custom relative SCR threshold from reaching eda_peaks. Unpack user kwargs in eda_methods (same pattern as rsp_methods) and keep the 0.1 default on eda_peaks. Fixes neuropsychology#1197
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1203 +/- ##
=======================================
Coverage 58.17% 58.18%
=======================================
Files 310 310
Lines 15702 15702
=======================================
+ Hits 9135 9136 +1
+ Misses 6567 6566 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1197.
eda_process()advertised**kwargsforwarding but then callededa_peaks(..., amplitude_min=0.1, **kwargs_peaks). The hardcoded keyword always won, and a customamplitude_minnever reached peak detection.eda_methods()also stored user kwargs under a nested"kwargs"key, soget_kwargs()could not pick them up (unlikersp_methods(), which unpacks**kwargsintoreport_info).The default remains 0.1 — that value still lives on
eda_peaks()— but callers can now do:amplitude_minis a relative threshold (fraction of the largest SCR), not an absolute conductance in siemens.Proposed Changes
eda_methods()the same wayrsp_methods()does.amplitude_min=0.1ineda_process(); leteda_peaks()supply the default.amplitude_minoneda_process().NEWS.rst.Checklist