[Fix] Calculate RSP phase durations from sample positions - #1201
Open
bipin-vishwakarma wants to merge 2 commits into
Open
[Fix] Calculate RSP phase durations from sample positions#1201bipin-vishwakarma wants to merge 2 commits into
bipin-vishwakarma wants to merge 2 commits into
Conversation
|
Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1201 +/- ##
=======================================
Coverage 58.17% 58.17%
=======================================
Files 310 310
Lines 15702 15703 +1
=======================================
+ Hits 9135 9136 +1
Misses 6567 6567 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Why
epochs_create()uses time values for the DataFrame index. Treating those labels as sample numbers and dividing bysampling_ratescales phase durations down a second time.Fixes #1196.
Tests
pytest tests/tests_rsp.py -k "rsp_intervalrelated" -q -o addopts=""(2 passed)tests/tests_rsp.pymodule: 25 passed across the regular run and the report test rerun withMPLBACKEND=Agg(local Python lacks Tk data)ruff check neurokit2/rsp/rsp_intervalrelated.py tests/tests_rsp.pyruff format --check neurokit2/rsp/rsp_intervalrelated.py tests/tests_rsp.py